Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add terraform provider support for new SCIM server api2 endpoints #980

Merged
merged 1 commit into from
Jul 18, 2024
Merged

Add terraform provider support for new SCIM server api2 endpoints #980

merged 1 commit into from
Jul 18, 2024

Conversation

acwest
Copy link
Contributor

@acwest acwest commented Jul 5, 2024 •
edited by developerkunal
Loading

🔧 Changes

  • Add resource for SCIM configuration management
  • Add data source for SCIM configuration management

📚 References

🔬 Testing

  1. Run unit tests to ensure that SCIM configuration is created correctly.
  2. Manually create SCIM resources and data sources to ensure they function properly.
  3. Verify in the UI that the SCIM configuration is properly created, read, updated, and deleted.

📝 Checklist

  • All new/changed/fixed functionality is covered by tests (or N/A)
  • I have added documentation for all new/changed functionality (or N/A)

@acwest acwest requested a review from a team as a code owner July 5, 2024 20:03
@acwest acwest force-pushed the DXCDT-644-Add-terraform-provider-support-for-new-SCIM-Server-API2-s-endpoints branch from 51cd673 to 617030f Compare July 5, 2024 20:07
@codecov-commenter
Copy link

codecov-commenter commented Jul 5, 2024 •
edited
Loading

Codecov Report

Attention: Patch coverage is 92.78846% with 15 lines in your changes missing coverage. Please review.

Project coverage is 90.28%. Comparing base (e3a495d) to head (ef28792).

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #980      +/-   ##
==========================================
- Coverage   90.28%   90.28%   -0.01%     
==========================================
  Files         103      105       +2     
  Lines       13918    14126     +208     
==========================================
+ Hits        12566    12753     +187     
- Misses        961      975      +14     
- Partials      391      398       +7
Files Coverage Δ
internal/auth0/connection/expand.go 92.30% <100.00%> (+0.22%) ⬆️
internal/auth0/connection/flatten.go 80.16% <100.00%> (+0.57%) ⬆️
internal/provider/provider.go 100.00% <ø> (ø)
internal/schema/schema.go 100.00% <100.00%> (ø)
internal/auth0/connection/data_source_scim.go 89.28% <89.28%> (ø)
internal/auth0/connection/resource_scim.go 91.08% <91.08%> (ø)

... and 1 file with indirect coverage changes

sergiught
sergiught suggested changes Jul 9, 2024
View reviewed changes
internal/provider/provider.go Outdated Show resolved Hide resolved
internal/provider/provider.go Outdated Show resolved Hide resolved
internal/auth0/organization/resource_connection.go Outdated Show resolved Hide resolved
internal/auth0/connection/schema.go Outdated Show resolved Hide resolved
internal/auth0/connection/schema.go Outdated Show resolved Hide resolved
internal/auth0/connection/resource_scim.go Outdated Show resolved Hide resolved
internal/auth0/connection/resource_scim.go Outdated Show resolved Hide resolved
internal/auth0/connection/resource_scim.go Outdated Show resolved Hide resolved
internal/auth0/connection/schema.go Outdated Show resolved Hide resolved
docs/resources/scim_configuration.md Outdated Show resolved Hide resolved
@acwest acwest force-pushed the DXCDT-644-Add-terraform-provider-support-for-new-SCIM-Server-API2-s-endpoints branch 3 times, most recently from 15cc933 to 75b13f2 Compare July 10, 2024 17:21
@acwest acwest requested a review from sergiught July 10, 2024 17:26
@acwest acwest force-pushed the DXCDT-644-Add-terraform-provider-support-for-new-SCIM-Server-API2-s-endpoints branch from 75b13f2 to 86ac4fc Compare July 10, 2024 17:43
@acwest acwest requested a review from developerkunal July 10, 2024 19:03
sergiught
sergiught previously requested changes Jul 11, 2024
View reviewed changes
examples/data-sources/auth0_connection_scim_configuration/data-source.tf Outdated Show resolved Hide resolved
examples/resources/auth0_connection_scim_configuration/resource.tf Outdated Show resolved Hide resolved
examples/resources/auth0_connection_scim_configuration/resource.tf Outdated Show resolved Hide resolved
examples/data-sources/auth0_connection_scim_configuration/data-source.tf Outdated Show resolved Hide resolved
internal/auth0/connection/resource_scim.go Outdated Show resolved Hide resolved
internal/auth0/connection/resource_scim.go Outdated Show resolved Hide resolved
internal/auth0/connection/resource_scim.go Outdated Show resolved Hide resolved
internal/auth0/connection/resource_scim.go Outdated Show resolved Hide resolved
internal/provider/provider.go Outdated Show resolved Hide resolved
internal/provider/provider.go Outdated Show resolved Hide resolved
@acwest acwest force-pushed the DXCDT-644-Add-terraform-provider-support-for-new-SCIM-Server-API2-s-endpoints branch 2 times, most recently from 5b1bc88 to f6a3a5e Compare July 16, 2024 13:18
developerkunal
developerkunal requested changes Jul 17, 2024
View reviewed changes
Copy link
Contributor

@developerkunal developerkunal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @acwest ,
can you take a look at changes i requested.

internal/auth0/connection/data_source_scim.go Show resolved Hide resolved
internal/auth0/connection/data_source_scim_test.go Outdated Show resolved Hide resolved
internal/auth0/connection/data_source_scim_test.go Outdated Show resolved Hide resolved
internal/auth0/connection/data_source_scim_test.go Outdated Show resolved Hide resolved
internal/auth0/connection/data_source_scim_test.go Outdated Show resolved Hide resolved
internal/auth0/connection/resource_scim_test.go Outdated Show resolved Hide resolved
internal/auth0/connection/resource_scim_test.go Outdated Show resolved Hide resolved
internal/auth0/connection/resource_scim_test.go Outdated Show resolved Hide resolved
internal/auth0/connection/resource_scim.go Outdated Show resolved Hide resolved
internal/auth0/connection/data_source_scim.go Outdated Show resolved Hide resolved
@acwest acwest force-pushed the DXCDT-644-Add-terraform-provider-support-for-new-SCIM-Server-API2-s-endpoints branch from 9c528b6 to fa7be65 Compare July 17, 2024 19:13
@acwest acwest mentioned this pull request Jul 17, 2024
Closed
2 tasks
developerkunal
developerkunal approved these changes Jul 18, 2024
View reviewed changes
Copy link
Contributor

@developerkunal developerkunal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@developerkunal developerkunal requested a review from sergiught July 18, 2024 01:49
@acwest acwest force-pushed the DXCDT-644-Add-terraform-provider-support-for-new-SCIM-Server-API2-s-endpoints branch from ea6dfd3 to ef28792 Compare July 18, 2024 01:51
@acwest acwest dismissed sergiught’s stale review July 18, 2024 01:57

Kunal and I have addressed his changes

@acwest acwest merged commit 946909b into main Jul 18, 2024
6 checks passed
@acwest acwest deleted the DXCDT-644-Add-terraform-provider-support-for-new-SCIM-Server-API2-s-endpoints branch July 18, 2024 02:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@developerkunal developerkunal developerkunal approved these changes

@sergiught sergiught Awaiting requested review from sergiught

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@acwest @codecov-commenter @sergiught @developerkunal